cloudflare / cloudflare/workerd

If pedantic_wpt is set, strictly validate Request fields even if not implemented

Open
#4,969 0 comments 0 reactions 0 assignees View on GitHub
wpt-conformance
Dominant language
C++
Stars
8.7k
Forks
739
Avg merge
2d 20h
Merged PRs (30d)
174

Description

Even if we don't implement certain request feartures, we should still validate that the passed options follow the standard:

For RequestInit specifically:
- RequestInit's window is not null
- Input URL has credentials
- RequestInit's mode is navigate
- RequestInit's referrer is invalid
- RequestInit's method is forbidden
- RequestInit's mode is no-cors and method is not simple
- Bad referrerPolicy init parameter value
- Bad mode init parameter value
- Bad credentials init parameter value
- Request with cache mode: only-if-cached and fetch mode: same-origin

In general:
- Check destination attribute
- Check referrer attribute
- Check referrerPolicy attribute
- Check mode attribute
- Check credentials attribute
- Check cache attribute
- Check isReloadNavigation attribute
- Check isHistoryNavigation attribute
- Check duplex attribute

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.