cloudflare / cloudflare/workerd

Bug in workers types generation logic

Open
#3,870 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
C++
Stars
8.7k
Forks
739
Avg merge
2d 20h
Merged PRs (30d)
174

Description

Ref: https://github.com/cloudflare/workerd/pull/3855#discussion_r2027280698

https://github.com/cloudflare/workerd/pull/3855 changed the constructor function of the `TextDecoder` class to include an additional `jsg::Lock&` argument as the first argument passed. When generating the types, the type generator ended up creating the definition so that both optional arguments ended up with the name `options`, causing typescript generation to fail. A manual override had to be used to produce the correct results.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.