cloudflare / cloudflare/workerd

🐛 BUG: console.trace support (regression)

Open
#2,278 1 comment 1 reaction 0 assignees View on GitHub
bug confirmed
Dominant language
C++
Stars
8.7k
Forks
739
Avg merge
2d 20h
Merged PRs (30d)
174

Description

### Which Cloudflare product(s) does this pertain to?

Wrangler core

### What version(s) of the tool(s) are you using?

3.53.1

### What version of Node are you using?

20.12.2

### What operating system and version are you using?

Windows 11

### Describe the Bug

`console.trace` is a really nice method for logging within functions and getting a stack-trace back to see where and how something was called. In complex workers apps, this would be very helpful.

Reference: https://developer.mozilla.org/en-US/docs/Web/API/console/trace_static

### Observed behavior

`console.trace` calls are swallowed and log nothing.

### Expected behavior

A trace should be logged, like in versions <= 3.14.0:

```
Trace: test
at logConsoleMessage (C:\Users\james\AppData\Local\npm-cache\_npx\51f9f4bffffff67a\node_modules\wrangler\wrangler-dist\cli.js:128126:25)
at WebSocket2. (C:\Users\james\AppData\Local\npm-cache\_npx\51f9f4bffffff67a\node_modules\wrangler\wrangler-dist\cli.js:127835:13)
at callListener (C:\Users\james\AppData\Local\npm-cache\_npx\51f9f4bffffff67a\node_modules\wrangler\wrangler-dist\cli.js:107228:18)
at WebSocket2.onMessage (C:\Users\james\AppData\Local\npm-cache\_npx\51f9f4bffffff67a\node_modules\wrangler\wrangler-dist\cli.js:107163:13)
at WebSocket2.emit (node:events:530:35)
at Receiver2.receiverOnMessage (C:\Users\james\AppData\Local\npm-cache\_npx\51f9f4bffffff67a\node_modules\wrangler\wrangler-dist\cli.js:108231:24)
at Receiver2.emit (node:events:518:28)
at Receiver2.dataMessage (C:\Users\james\AppData\Local\npm-cache\_npx\51f9f4bffffff67a\node_modules\wrangler\wrangler-dist\cli.js:106513:18)
at Receiver2.getData (C:\Users\james\AppData\Local\npm-cache\_npx\51f9f4bffffff67a\node_modules\wrangler\wrangler-dist\cli.js:106442:21)
at Receiver2.startLoop (C:\Users\james\AppData\Local\npm-cache\_npx\51f9f4bffffff67a\node_modules\wrangler\wrangler-dist\cli.js:106183:26)
```
(arguably not that useful since that's not userland code, but at least you get something)

### Steps to reproduce

Using the following script:
```typescript
export default {
async fetch(request: Request, env: Env, ctx: ExecutionContext): Promise {
console.trace('test');

return new Response('Hello world!');
},
};
```

- `npx wrangler@3.14.0 dev` - logs a trace
- `npx wrangler@3.15.0 dev` - no trace, no error, just swallowed
- `npx wrangler@3.53.1 dev` - no trace, no error, just swallowed

I previously opened this as a feature request at https://github.com/cloudflare/workers-sdk/issues/5761, but have since realised this is a regression.

Related: https://github.com/cloudflare/workerd/issues/2247

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.