cloudflare / cloudflare/tls-tris

Validation of unexpected extensions

Open
#48 0 comments 0 reactions 0 assignees View on GitHub
bogo
Dominant language
Go
Stars
300
Forks
52
PR merge metrics
No merged PRs in 30d

Description

Currently unexpected extensions are silently ignored, but these must result in a failure. Similarly, duplicate extensions are not checked at the moment.

The following requirements are imposed from https://tools.ietf.org/html/draft-ietf-tls-tls13-18#page-35:

> If the client receives an extension which is not specified for a given
> message it MUST abort the handshake with an "illegal_parameter"
> alert.

> Upon receiving an unexpected extension, it MUST abort the handshake
> with an "unsupported_extension" alert.

> There MUST NOT be more than one extension of the same type.

Addressing these issues will fix a bunch of bogo failures.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.