cloudflare / cloudflare/sslconfig
HPACK patch broken for Nginx 1.13.10
- Dominant language
- No language data
- Stars
- 1.3k
- Forks
- 142
- PR merge metrics
- No merged PRs in 30d
Description
Using @PikachuEXE patch https://github.com/cloudflare/sslconfig/pull/92
```
patching file auto/modules
Hunk #1 succeeded at 438 (offset 1 line).
patching file auto/options
Hunk #2 succeeded at 224 (offset 1 line).
Hunk #3 succeeded at 436 (offset 2 lines).
patching file src/core/ngx_murmurhash.c
patching file src/core/ngx_murmurhash.h
patching file src/http/v2/ngx_http_v2.c
Hunk #1 succeeded at 270 (offset -2 lines).
Hunk #2 succeeded at 2056 (offset 1 line).
patching file src/http/v2/ngx_http_v2.h
Hunk #1 succeeded at 52 (offset 1 line).
Hunk #2 succeeded at 123 (offset 1 line).
Hunk #3 succeeded at 178 (offset 1 line).
Hunk #4 succeeded at 207 (offset 1 line).
Hunk #5 succeeded at 465 with fuzz 2 (offset 53 lines).
patching file src/http/v2/ngx_http_v2_filter_module.c
Hunk #1 FAILED at 26.
Hunk #2 FAILED at 93.
Hunk #3 succeeded at 155 (offset -41 lines).
Hunk #4 succeeded at 433 (offset -41 lines).
Hunk #5 succeeded at 441 (offset -41 lines).
Hunk #6 succeeded at 449 (offset -41 lines).
Hunk #7 succeeded at 467 (offset -41 lines).
Hunk #8 succeeded at 514 (offset -41 lines).
Hunk #9 succeeded at 566 with fuzz 1 (offset -41 lines).
Hunk #10 FAILED at 1039.
Hunk #11 FAILED at 1065.
4 out of 11 hunks FAILED -- saving rejects to file src/http/v2/ngx_http_v2_filter_module.c.rej
patching file src/http/v2/ngx_http_v2_table.c
Hunk #1 succeeded at 361 (offset 14 lines).
```
Contributor guide
Research direction
Start by applying the linked @PikachuEXE patch to Nginx 1.13.10 and inspect the rejected hunks in src/http/v2/ngx_http_v2_filter_module.c, along with the listed changes in auto/modules, auto/options, and the other src files. Done means the HPACK patch applies cleanly to Nginx 1.13.10 without rejected hunks.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- nginx
- Domain
- networking
- Issue type
- Bug
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 25/100