cloudflare / cloudflare/sslconfig
About NGX_SSL_MAX_SESSION_SIZE in nginx__dynamic_tls_records.patch
Open
- Dominant language
- No language data
- Stars
- 1.3k
- Forks
- 142
- PR merge metrics
- No merged PRs in 30d
Description
Hello,
In nginx__dynamic_tls_records.patch, the change made at line 139 (https://github.com/cloudflare/sslconfig/blob/master/patches/nginx__dynamic_tls_records.patch#L139) seems unrelated to the patch for dynamic record size. I don't know much about nginx programming but the define NGX_SSL_MAX_SESSION_SIZE is never used in the patch.
Same thing in the new patch for nginx 1.11.5, at line 124 : https://github.com/cloudflare/sslconfig/blob/master/patches/nginx__1.11.5_dynamic_tls_records.patch#L124
Contributor guide
Assessment
This issue has not been assessed yet.