cloudflare / cloudflare/speedtest
Improve TS type for onResultsChange callback parameter
Open
- Dominant language
- TypeScript
- Stars
- 738
- Forks
- 83
- Avg merge
- 1d 12h
- Merged PRs (30d)
- 6
Description
The `onResultsChange` callback in `src/index.d.ts` has a loosely typed parameter:
```ts
onResultsChange: ({ type: string }) => void;
```
This should be a union type matching the MeasurementConfig types to provide better type safety:
```ts
onResultsChange: ({ type: 'download' | 'upload' | 'latency' | 'packetLoss' }) => void;
```
or
```ts
onResultsChange: (change: { type: MeasurementConfig['type'] }) => void;
```
Contributor guide
Assessment
This issue has not been assessed yet.