cloudflare / cloudflare/serverless-cloudflare-workers

Exit code 0 when script fails to deploy

Open
#33 2 comments 9 reactions 0 assignees View on GitHub
Dominant language
JavaScript
Stars
180
Forks
34
PR merge metrics
No merged PRs in 30d

Description

We had a mistake in our serverless function, but the exit code of `serverless deploy` was still 0, even though this plugin reported a "Fatal Error".

```
./node_modules/serverless/bin/serverless deploy
Serverless: Packaging service...
Serverless: Excluding development dependencies...
Serverless: Starting Serverless Cloudflare-Worker deployment.
Serverless: deploying route: https://my-route.example.com/*
Serverless: ❌ Fatal Error, Script Not Deployed!
Serverless: --> Error Code:10021
--> Error Message: "Uncaught ReferenceError: window is not defined
at line 16
at line 1 in r
at line 1
at line 1
"
Serverless: ✅ Routes Deployed
Serverless: Finished deployment in 6.789 seconds.
Serverless: Finished Serverless Cloudflare-Worker deployment.
exit code: 0 duration: 8s
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.