cloudflare / cloudflare/quiche

qlog-dancer: wasm build fails to compile (f32/f64 type mismatches in web.rs)

Open Beginner friendly
#2,519 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
11.8k
Forks
1.1k
Avg merge
21h 9m
Merged PRs (30d)
6

Description

`wasm-pack build --target=web` in `qlog-dancer/` fails:

```
error[E0308]: mismatched types
--> qlog-dancer/src/web.rs:740:26
|
740 | end: x_end,
| ^^^^^ expected `Option`, found `Option`
|
= note: expected enum `std::option::Option`
found enum `std::option::Option`

error[E0308]: mismatched types
--> qlog-dancer/src/web.rs:763:58
|
763 | Some(ChartInfo::::with_u64_f32(&chart));
| ----------------------------------- ^^^^^^ expected `RangedCoordf32`, found `RangedCoordf64`
| |
| arguments to this function are incorrect
|
= note: expected reference `&plotters::chart::ChartContext<'_, _, plotters::prelude::Cartesian2d<_, RangedCoordf32>>`
found reference `&plotters::chart::ChartContext<'_, _, plotters::prelude::Cartesian2d<_, RangedCoordf64>>`
```

Bug was introduced by https://github.com/cloudflare/quiche/pull/2386

This was not caught by CI because qlog-dancer is excluded.

Contributor guide

Open the contributing guide

Research direction

Run `wasm-pack build --target=web` in `qlog-dancer/` and inspect the reported mismatches in `qlog-dancer/src/web.rs` around lines 740 and 763. Trace the chart types used there and verify that the build completes successfully after the type mismatch is resolved.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust, wasm
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Quiet
Clarity
Clearly specified
Newbie friendliness
82/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.