cloudflare / cloudflare/quiche

Make PTO duration usage and calculation uniform

Open
#2,369 1 comment 0 reactions 0 assignees View on GitHub
good first issue
Dominant language
Rust
Stars
11.8k
Forks
1.1k
Avg merge
21h 9m
Merged PRs (30d)
6

Description

We have a few `p.recovery.pto * 3` calculations scattered throughout the codebase. These seem to be used for calculating timeouts. It would be nice to have this logic extracted into its own function.

Examples:
- https://github.com/cloudflare/quiche/blob/83f919f0dcf49f973f8f425a4dcd5754fc47fe33/quiche/src/lib.rs#L8452-L8455
- https://github.com/cloudflare/quiche/blob/83f919f0dcf49f973f8f425a4dcd5754fc47fe33/quiche/src/lib.rs#L3233
- https://github.com/cloudflare/quiche/blob/83f919f0dcf49f973f8f425a4dcd5754fc47fe33/quiche/src/lib.rs#L4706

Contributor guide

Open the contributing guide

Research direction

Start in quiche/src/lib.rs at the three referenced locations and inspect how p.recovery.pto * 3 is used for timeouts. Locate all equivalent calculations, extract the shared logic into a function, and replace the scattered uses. Done means timeout calculations use the common function consistently.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
networking
Issue type
Refactor
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.