cloudflare / cloudflare/quiche

Calling `Connection::close()` should prevent any application data from being written

Open
#1,750 1 comment 0 reactions 1 assignee Claimed by @evanrittenhouse View on GitHub
Dominant language
Rust
Stars
11.8k
Forks
1.1k
Avg merge
21h 9m
Merged PRs (30d)
6

Description

[close()](https://github.com/cloudflare/quiche/blob/master/quiche/src/lib.rs#L6237) writes a CONNECTION_CLOSE to the connection, but doesn't immediately set the connection's drain timer. This means that applications can write data to the connection which should effectively never be processed, by virtue of it being preceded by a CONNECTION_CLOSE.

We should just immediately set the draining timer to prevent sending extra data over the wire

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.