cloudflare / cloudflare/quiche

`SmallVec` with length 1

Open
#1,746 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
11.8k
Forks
1.1k
Avg merge
21h 9m
Merged PRs (30d)
6

Description

https://github.com/cloudflare/quiche/blob/098664eb001c38a8370a09a4b0d99c8126320e95/qlog/src/events/quic.rs#L651

This allocates a `SmallVec` that spills on the heap when the second element is inserted, which is probably much earlier than you want. Suggest bumping this up to 8 or 16 or something (whatever number you think a good bound for the number of frames in most QUIC packets is.)

You might also want to review other uses of `SmallVec` in quiche.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.