cloudflare / cloudflare/quiche

TlsFail does not contain the underlying error info

Open
#1,129 3 comments 2 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
11.8k
Forks
1.1k
Avg merge
21h 9m
Merged PRs (30d)
6

Description

`Error::TlsFail` is used a generic error code for most TLS errors. However sometimes it's important to find out what the actual cause is. For example:

https://github.com/cloudflare/quiche/blob/a9ee599a7bf9f4365d4368c1b0d8e7b92bf2424f/quiche/src/tls.rs#L189

and

https://github.com/cloudflare/quiche/blob/a9ee599a7bf9f4365d4368c1b0d8e7b92bf2424f/quiche/src/tls.rs#L988-L993

In my case, load_cert_chain_from_pem_file failed intermittently but only returned `TlsFail` without further info. Is there any plan to bubble up the underlying error info in such TLS failures?

Contributor guide

Open the contributing guide

Research direction

Start in quiche/src/tls.rs at the referenced TLS error paths around lines 189 and 988-993, then trace load_cert_chain_from_pem_file and its callers. Determine how TLS failures are represented and reported, and check existing error tests. Done means callers can access the underlying cause instead of receiving only TlsFail, including intermittent certificate-loading failures.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
networking
Issue type
Feature
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.