cloudflare / cloudflare/pingora

Security audit workflow still filters pushes to master

Open Beginner friendly
#984 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
27.4k
Forks
1.7k
Avg merge
6h 22m
Merged PRs (30d)
3

Description

The repository uses `main`, but `.github/workflows/audit.yml` still limits its `push` trigger to `master`.

As a result, changes to `Cargo.toml` on `main` do not trigger the security audit; only the scheduled run does. The workflow was introduced in #135 with `main` as the PR base, so this appears to have been stale from the start.

The branch filter should use `main` (or be removed if the audit should run on dependency changes across branches).

Contributor guide

Open the contributing guide

Research direction

Open .github/workflows/audit.yml and inspect its push trigger and branch filter, then compare them with the repository's main branch and the dependency-change context in Cargo.toml. Done means pushes to main trigger the security audit as intended, or the workflow's branch behavior is deliberately broadened; verify the workflow remains valid.

Written by the indexing model from the issue text.

Assessment

Tech stack
github-actions, rust
Domain
ci-cd, security
Issue type
Bug
Difficulty
1/5
Estimated time
Under an hour
Activity status
Active
Clarity
Clearly specified
Newbie friendliness
92/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.