cloudflare / cloudflare/pingora

pingora-http test fails on patched_http1 feature

Open
#481 0 comments 0 reactions 1 assignee Claimed by @johnhurt View on GitHub
Dominant language
Rust
Stars
27.4k
Forks
1.7k
Avg merge
6h 22m
Merged PRs (30d)
3

Description

## Describe the bug

On running `cargo test --all --features=patched_http1` on pingora-http crate, the following error is logged

```
Compiling pingora-http v0.4.0 (/home/vivekdeb/Debian_Packaging/debcargo-conf/build/pingora-http)
Finished `test` profile [unoptimized + debuginfo] target(s) in 0.58s
Running unittests src/lib.rs (target/debug/deps/pingora_http-6e4dc386229d77ba)

running 8 tests
test tests::header_map_upper_bound ... ok
test case_header_name::tests::test_case_header_name ... ok
test tests::set_test_send_end_stream ... ok
test tests::test_reason_phrase ... ok
test tests::test_multiple_header ... ok
test tests::test_invalid_path ... FAILED
test tests::test_single_header ... ok
test tests::test_single_header_no_case ... ok

failures:

---- tests::test_invalid_path stdout ----
thread 'tests::test_invalid_path' panicked at src/lib.rs:715:68:
called `Result::unwrap()` on an `Err` value: Error { etype: InvalidHTTPHeader, esource: Unset, retry: Decided(false), cause: None, context: Some(Owned("invalid uri Hello�World")) }
note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace

failures:
tests::test_invalid_path

test result: FAILED. 7 passed; 1 failed; 0 ignored; 0 measured; 0 filtered out; finished in 0.00s

error: test failed, to rerun pass `--lib`
```

**Pingora version**: 0.4.0
**Rust version**: i.e. `cargo --version` 1.82.0
**Operating system version**: Debian Sid

## Expected results

All tests pass successfully

## Observed results

one of the feature test fails

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.