cloudflare / cloudflare/pingora
`proxy_upstream_filter` return value has opposite meaning
Open
ergonomics
- Dominant language
- Rust
- Stars
- 27.4k
- Forks
- 1.7k
- Avg merge
- 6h 22m
- Merged PRs (30d)
- 3
Description
For `request_filter` , a return value of `Ok(false)` continues to the next phase.
For `proxy_upstream_filter`, `Ok(true)` continues to the next phase.
All of the other methods of `ProxyHttp` with a `Result` signature return `Ok(false`) by default.
Could `proxy_upstream_filter` also follow this pattern, returning `Ok(false)` to continue?
Contributor guide
Assessment
This issue has not been assessed yet.