cloudflare / cloudflare/partykit

Should onError be an async function?

Open
#91 2 comments 0 reactions 0 assignees View on GitHub
Dominant language
TypeScript
Stars
1.3k
Forks
79
PR merge metrics
No merged PRs in 30d

Description

Just ran into an issue where I found myself wanting `onError` to be `async` so I could use an `await` in there.

https://github.com/threepointone/partyserver/blob/main/packages/partyserver/src/index.ts#L524

Does this seem reasonable, and if so hopefully it's not a big change?

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.