cloudflare / cloudflare/networkquality-rs

MacOS Build boring/tokio-boring version

Open
#17 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
94
Forks
15
Avg merge
1d 13m
Merged PRs (30d)
1

Description

I was building on Mac and I got the following
```
$>cargo build --release
...
...
...
Compiling boring v4.7.0
error[E0425]: cannot find function, tuple struct or tuple variant `PEM_write_bio_DHparams` in crate `ffi`
--> /Users/panagiotisvouzis/.cargo/registry/src/index.crates.io-6f17d22bba15001f/boring-4.7.0/src/dh.rs:33:14
|
33 | ffi::PEM_write_bio_DHparams
| ^^^^^^^^^^^^^^^^^^^^^^ not found in `ffi`

error[E0425]: cannot find function, tuple struct or tuple variant `PEM_read_bio_DHparams` in crate `ffi`
--> /Users/panagiotisvouzis/.cargo/registry/src/index.crates.io-6f17d22bba15001f/boring-4.7.0/src/dh.rs:67:14
|
67 | ffi::PEM_read_bio_DHparams
| ^^^^^^^^^^^^^^^^^^^^^ not found in `ffi`

error[E0425]: cannot find function, tuple struct or tuple variant `PEM_write_bio_DSA_PUBKEY` in crate `ffi`
--> /Users/panagiotisvouzis/.cargo/registry/src/index.crates.io-6f17d22bba15001f/boring-4.7.0/src/dsa.rs:92:14
|
92 | ffi::PEM_write_bio_DSA_PUBKEY
| ^^^^^^^^^^^^^^^^^^^^^^^^ not found in `ffi`

```

I had to make this change to fix it:
```
--- a/Cargo.toml
+++ b/Cargo.toml
@@ -26,7 +26,7 @@ nq-tokio-network = { path = "./crates/nq-tokio-network" }

anyhow = "1.0"
async-trait = { version = "0.1" }
-boring = "4.1"
+boring = "4.10.3"
clap = "4.3"
clap-verbosity-flag = "2.1"
http = "1.0"
@@ -42,5 +42,5 @@ tracing = "0.1"
tracing-subscriber = "0.3"
tokio = "1.0"
tokio-util = "0.7"
-tokio-boring = "4.1"
+tokio-boring = "4.10.3"
url = "2.4"
```

Contributor guide

Open the contributing guide

Research direction

Start in Cargo.toml with the boring and tokio-boring dependency entries, then compare them with the versions shown in the issue. Run cargo build --release on macOS and confirm the missing ffi symbols no longer prevent compilation; there is no test file mentioned.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
build-system
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.