cloudflare / cloudflare/lua-resty-logger-socket

request help: use this lib in nginx stream subsystem

Open
#58 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Raku
Stars
493
Forks
128
PR merge metrics
No merged PRs in 30d

Description

Hi folks, thank you for open sourcing this lib.

I tried using this lib in the Nginx stream subsystem, and it works well, but I found that the judgment here always comes up when running the test case:

https://github.com/cloudflare/lua-resty-logger-socket/blob/15cc1c256e55b8e68ec9b220b6883c227a763d4e/lib/resty/logger/socket.lua#L31-L39

In the Nginx http subsystem, `ngx.config` looks like this:

```
{
debug = true,
nginx_configure = ,
nginx_version = 1019009,
ngx_lua_version = 10020,
prefix = ,
subsystem = "http"
}
```

and in Nginx stream subsystem,`ngx.config` looks like this:

```
{
debug = true,
nginx_configure = ,
nginx_version = 1019009,
ngx_lua_version = 10,
prefix = ,
subsystem = "stream"
}
```

I would be happy to submit a PR to improve this issue if you agree to be compatible with Nginx streams subsystem here.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.