cloudflare / cloudflare/helm-charts

Resources key not honoured (cloudflare-tunnel-remote)

Open
#105 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Smarty
Stars
141
Forks
96
PR merge metrics
No merged PRs in 30d

Description

The values file in `cloudflare-tunnel-remote` shows the use of the `resources` key:
```
resources: {}
# We usually recommend not to specify default resources and to leave this as a conscious
# choice for the user. This also increases chances charts run on environments with little
# resources, such as Minikube. If you do want to specify resources, uncomment the following
# lines, adjust them as necessary, and remove the curly braces after 'resources:'.
# limits:
# cpu: 100m
# memory: 128Mi
# requests:
# cpu: 100m
# memory: 128Mi
```
However, the deployment template never looks at this key to actually update the resources. This is very strange as a search of the repository shows that this was fixed in PR #65 but that change does not appear in the history for the deployment template.

Contributor guide

Open the contributing guide

Research direction

In the cloudflare-tunnel-remote chart, compare the values file's resources key with the deployment template and review PR #65 for the related fix. The work is done when the deployment template honors the configured resources values.

Written by the indexing model from the issue text.

Assessment

Tech stack
helm, kubernetes
Domain
devops, infrastructure
Issue type
Bug
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
52/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.