cloudflare / cloudflare/go

crypto/tls: Vet interaction between ECH and PSK

Open
#74 1 comment 1 reaction 1 assignee Claimed by @cjpatton View on GitHub
bug
Dominant language
Go
Stars
370
Forks
62
PR merge metrics
No merged PRs in 30d

Description

We may have a bug in crypto/tls that would be triggered by ECH rejection when the server supports PSK. The bug would cause the handshake to fail. I will investigate soon, unless someone gets there first. The temporary fix should be as simple as disabling ECH+PSK. It's likely that the spec will be changed in a way that allows us to properly patch this problem without a major refactor. See https://github.com/tlswg/draft-ietf-tls-esni/issues/399.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.