cloudflare / cloudflare/cloudflared

Wrong case in websocket headers

Open
#416 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
15.6k
Forks
1.4k
PR merge metrics
No merged PRs in 30d

Description

Server-side capture from a cloudflared-tunneled websocket system:

```
Sec-Websocket-Protocol
```

From the RFC and from native browsers
```
Sec-WebSocket-Protocol
```

Note the case of the S. Affects all websocket headers. While this is technically allowed, it runs into issues with applications expecting exact case from the standard. Since native browsers send the standard's casing, cloudflare's websocket client should too.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.