cloudflare / cloudflare/cloudflared
🐛Update Process Returns Errors for Non-error Conditions
- Dominant language
- Go
- Stars
- 15.6k
- Forks
- 1.4k
- PR merge metrics
- No merged PRs in 30d
Description
**Describe the bug**
Running `cloudflared update` will return an error in two possible conditions that are not errors:
1. Cloudflared is updated successfully
2. Cloudflared is already up-to-date
**To Reproduce**
Steps to reproduce the behavior:
1. Install cloudflared
2. Run `cloudflared update`
3. See error
OR
1. Install old version of cloudflared
2. Run `cloudflared update`
3. See error
**Expected behavior**
A standard non-error message indicating that either a) update was successful, or b) no update was needed.
**Environment and versions**
- OS: Windows Server 2016 and Windows 11
- Architecture: Intel 64-bit
- Version: 2023.5.0, and 2023.7.2
**Logs and errors**
```
PS C:\> cloudflared version
cloudflared version 2023.5.0 (built 2023-05-01-2145 UTC)
PS C:\> cloudflared update
cloudflared : 2023-08-18T19:00:07Z INF cloudflared has been updated version=2023.7.3
At line:1 char:1
+ cloudflared update
+ ~~~~~~~~~~~~~~~~~~
+ CategoryInfo : NotSpecified: (2023-08-18T19:0...ersion=2023.7.3:String) [], RemoteException
+ FullyQualifiedErrorId : NativeCommandError
cloudflared has been updated to version 2023.7.3
PS C:\> cloudflared version
cloudflared version 2023.7.3 (built 2023-07-26-1526 UTC)
PS C:\> cloudflared update
cloudflared : 2023-08-18T19:01:14Z INF cloudflared is up to date version=
At line:1 char:1
+ cloudflared update
+ ~~~~~~~~~~~~~~~~~~
+ CategoryInfo : NotSpecified: (2023-08-18T19:0...o date version=:String) [], RemoteException
+ FullyQualifiedErrorId : NativeCommandError
```
Contributor guide
Assessment
This issue has not been assessed yet.