cloudflare / cloudflare/cloudflare-rs

Types ambiguities

Open
#265 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
316
Forks
111
PR merge metrics
No merged PRs in 30d

Description

There are ambiguities in the types, comparing to both the official documentation and what we're actually getting on the endpoint. Should we match the former to align with the docs, or the latter to align with reality?

* `workerskv::WorkersKvBulkResult`: `unsuccessful_keys` does not seem to be optional. Rather, we just get an empty vector if the list is empty.
* `workerskv::write_bulk::KeyValuePair` doesn't reflect the official documentation, but neither does this one make sense either. Having everything optional isn't right. What should we do?
* `zone::Zone`: `plan` doesn't appear in the documentation, neither does it appear in the official TypeScript library.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.