cloudflare / cloudflare/cloudflare-rs

Derive `Eq` for `DnsContent`

Open
#226 0 comments 1 reaction 0 assignees View on GitHub
Dominant language
Rust
Stars
316
Forks
111
PR merge metrics
No merged PRs in 30d

Description

Currently, comparisons between `DnsContent` instances require explicit matching of the enum variants.

```rust
let dns1: DnsContent = ...;
let dns2: DnsContent = ...;

let is_same_record: bool = match (dns1, dns2) {
(DnsContent::A { content: ip1 }, DnsContent::A { content: ip2 }) => ip1 == ip2,
// ...
_ => false
};
```

Deriving `Eq` (and therefore `PartialEq`), `DnsContent` instances can be compared using the `==` operator, providing a more ergonomic API to interact with DNS records.

```rust
let dns1: DnsContent = ...;
let dns2: DnsContent = ...;

let same_record: bool = dns1 == dns2;
```

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.