cloudflare / cloudflare/cloudflare-php

Adapter Interface should not enforce constructor

Open
#145 1 comment 1 reaction 0 assignees View on GitHub
Dominant language
PHP
Stars
674
Forks
268
PR merge metrics
No merged PRs in 30d

Description

https://github.com/cloudflare/cloudflare-php/blob/master/src/Adapter/Adapter.php#L26

```
interface Adapter
{
/**
* Adapter constructor.
*
* @param Auth $auth
* @param string $baseURI
*/
public function __construct(Auth $auth, string $baseURI);
```
An interface should not enforce any constructor as this is an implementation-issue

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.