Miscellaneous issues raised during review of Dilithium PR
Open
- Dominant language
- Go
- Stars
- 1.7k
- Forks
- 219
- Avg merge
- 15h 45m
- Merged PRs (30d)
- 4
Description
- [ ] Does it negatively impact performance if we implement `ShakeHash` on `AesStream` to simplify the sampling code. (Due to esacape-to-heap allocations.)
- [ ] How far to go to [check keys for consistency](https://github.com/cloudflare/circl/pull/87#discussion_r409195376)
- [x] Document which files `gen.go` generates.
- [x] Reconsider code layout.
- [ ] Use `intenal/test` when appropriate
Contributor guide
Assessment
This issue has not been assessed yet.