cloudflare / cloudflare/cfssl

Issue with cfssl-scan

Open
#758 6 comments 0 reactions 0 assignees View on GitHub
Dominant language
Go
Stars
9.5k
Forks
1.2k
PR merge metrics
No merged PRs in 30d

Description

I'm running the latest code-base for cfssl-scan on OSX and Linux and get the following error when I scan some https sites like chase.com, wellsfargo.com. However when I scan google.com and cloudflare.com there is no problem. I debugged the code and the problem seems to on the line 290 of cfssl/scan/vendor/crypto/tls/handshake_client.go

285 switch certs[0].PublicKey.(type) {
286 case *rsa.PublicKey, *ecdsa.PublicKey:
287 break
288 default:
289 c.sendAlert(alertUnsupportedCertificate)
290 return fmt.Errorf("tls: server's certificate contains an unsupported type of public key: %T",
certs[0].PublicKey)
}

$ cfssl scan -scanner=TLSDial chase.com
Scanning chase.com...
=== chase.com ===
{
"Connectivity": {
"TLSDial": {
"grade": "Bad",
"error": "tls: server's certificate contains an unsupported type of public key: *rsa.PublicKey"
}
}
}

$ cfssl scan -scanner=TLSDial cloudflare.com
Scanning cloudflare.com...
=== cloudflare.com ===
{
"Connectivity": {
"TLSDial": {
"grade": "Good"
}
}
}

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.