cloudflare / cloudflare/boringtun
Keeping timers relative to start of tunnel initiation is confusing
Open
code quality
good first issue
- Dominant language
- Rust
- Stars
- 7.2k
- Forks
- 532
- PR merge metrics
- No merged PRs in 30d
Description
Keeping timers this way means that for example `update_session_timers` takes a `time_now` param that's a `Duration` instead of an `Instant`. All entries in `Tunn::timers` are `Duration`s when many of them are "the time that something happened" and idiomatically I think these would be better expressed as `Instant`s.
Contributor guide
Assessment
This issue has not been assessed yet.