cloudflare / cloudflare/boring

tokio-boring: Can't get Error(Stack) out of HandshakeError

Open
#405 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
Rust
Stars
522
Forks
171
PR merge metrics
No merged PRs in 30d

Description

A `tokio_boring::HandshakeError` wraps a `boring::ssl::HandshakeError` with a different stream type. However, the latter exposes either an `ErrorStack` (if the failure was in setup) or an `ssl::Error` (if the failure was actually during the handshake), while the former provides no way to get at either besides the `code()` and `as_io_error()` accessors (and stringification). This is frustrating for us (Signal), where we'd like to log errors but only if we can guarantee they don't have user data in them; as is, we can only log the `code()` when using a tokio handshake, which often omits the actual reason a handshake failed.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.