cloudflare / cloudflare/binary-install

Add option to remove only binary or whole directory

Open
#4 0 comments 0 reactions 0 assignees View on GitHub
enhancement status - PR Welcome
Dominant language
JavaScript
Stars
48
Forks
23
PR merge metrics
No merged PRs in 30d

Description

Currently, `binary-install` assumes that uninstalling should remove the entire directory from the user's machine, however some libraries may have application-specific code in that directory. If that is the case, they may want to give users the choice of whether or not they want to remove application-specific code, or just the binary.

`binary-install` should remove the entire directory by default, but should allow library consumers to toggle the feature where the user is prompted to either remove the entire directory or just the binary.

current code in `uninstall` that should remain the default

```js
if (existsSync(this._getInstallDirectory())) {
rimraf.sync(this.installDirectory);
console.log(
`${this.name ? this.name : "Your package"} has been uninstalled`
);
}
```

if the user passes `option.uninstallPrompt = true`

```
"Would you like to remove all of your data associated with ${this.name}`? (y/n)
```

if y -> use existing default code

if n -> `fs.unlink(this._getBinaryPath())`

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.