cloudflare / cloudflare/authr

Avoid using `any` type

Open
#26 0 comments 0 reactions 0 assignees View on GitHub
Dominant language
PHP
Stars
53
Forks
9
PR merge metrics
No merged PRs in 30d

Description

I really like this package and the fact that a company with a strong engineering background is behind it.

But the use of `any` everywhere is really deterring me from using this.

Especially in the cases where types are most needed, such as rule creation:

https://github.com/cloudflare/authr/blob/3f6129d97d06e61033a7f237d84e35e678db490f/ts/src/rule.ts#L39

But the same pattern is used everywhere.

It is best practice to never use `any`, and in those cases where you truly don't know what the type should be, then use `unknown` type.

Contributor guide

Open the contributing guide

Assessment

This issue has not been assessed yet.

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.