cloudevents / cloudevents/sdk-java
Avro compact deserializer bug - ID set to type
Nobody has claimed this yet.
- Dominant language
- Java
- Stars
- 446
- Forks
- 172
- PR merge metrics
- No merged PRs in 30d
Description
Looks like accidental set of ID to type.
https://github.com/cloudevents/sdk-java/blob/main/formats/avro-compact/src/main/java/io/cloudevents/avro/compact/AvroCompactFormat.java#L90
Should be:
.withId(from.getId())
Test should be fixed as well. Using different values in type and ID of the test event would detect the issue.
https://github.com/cloudevents/sdk-java/blob/main/formats/avro-compact/src/test/java/io/cloudevents/avro/compact/AvroCompactFormatTest.java#L46
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with formats/avro-compact/src/main/java/io/cloudevents/avro/compact/AvroCompactFormat.java around line 90, then inspect the related test at formats/avro-compact/src/test/java/io/cloudevents/avro/compact/AvroCompactFormatTest.java around line 46. Update the ID handling as indicated and use different type and ID values in the test so the bug is detected; run the Avro compact format tests to confirm the fix.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- java
- Domain
- backend
- Issue type
- Bug
- Difficulty
- 1/5
- Estimated time
- 1-3 hours
- Activity status
- Quiet
- Clarity
- Clearly specified
- Newbie friendliness
- 88/100