cloudevents / cloudevents/sdk-csharp
Review HTTP tests carefully
Open
@jskeet is already working on this.
Since Feb 4, 2021.
- Dominant language
- C#
- Stars
- 334
- Forks
- 88
- Avg merge
- 7m
- Merged PRs (30d)
- 2
Description
Currently our ASP.NET Core integration test only works because when you create an HttpContent from an event without data, in binary mode, the formatter ends up creating content of "null" (as four bytes). If there's no data, we shouldn't be specifying a DataContentType or populating the request body - but that throws at the moment.
Likewise other HTTP tests specify a content type of XML despite using a JSON event formatter - it's not clear what the expected behaviour is there, in general. (That's related to #55.)
Contributor guide
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Assessment
This issue has not been assessed yet.