cloudamqp / cloudamqp/cli

instance upgrade-versions vs. instance node versions

Open
#28 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

bug
Dominant language
Go
Stars
2
Forks
1
PR merge metrics
No merged PRs in 30d

Description

I feel like this is quite confusions:

$ ./cloudamqp instance upgrade-versions --id 351604
Upgrade versions:
{
  "new_erlang_version": "28.1.1",
  "new_rabbitmq_version": "4.2.2"
}

$ ./cloudamqp instance nodes versions --id 351604
Available versions:
RabbitMQ versions: [4.2.2 4.2.1 4.2.0 4.2.0-rc.1 4.2.0-beta.4 4.2.0-beta.3 4.1.7 4.1.6 4.1.5]
Erlang versions: [27.3.4.6]
  • Which one should I use?
  • Why is one under nodes and not the other one?
  • One gives JSON, the other an interesting list syntax :)
  • upgrade-versions sounds like an action, not a query

How can we simplify? :)

For example, maybe

/cloudamqp instance upgrade-versions --id 351604 should be ./cloudamqp instance upgrade-all --dry-run?

There's also a lot of upgrade actions, do we need all? Should be enough with one and ability to specify just rabbit/erlang if that's important.

  upgrade-all        Upgrade RabbitMQ and Erlang
  upgrade-erlang     Upgrade Erlang
  upgrade-rabbitmq   Upgrade RabbitMQ
  upgrade-versions   Fetch upgrade versions

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by tracing the implementations of the listed instance commands: upgrade-all, upgrade-erlang, upgrade-rabbitmq, upgrade-versions, and nodes versions. Compare their purposes and output formats, then review the issue's proposed dry-run and consolidated-command behavior. Done means the upgrade interface has a clear, consistent naming and query/action distinction, with the resulting behavior reflected in the CLI.

Written by the indexing model from the issue text.

Assessment

Tech stack
go
Domain
cli
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.