Unique tasks should be unique per queue
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 1.5k
- Forks
- 95
- Avg merge
- 4d 21h
- Merged PRs (30d)
- 1
Description
When removing a unique task from a queue, we check other states (e.g. scheduled / error / etc.) before removing the task object from Redis to make sure the task is not referenced anywhere else. However, we don't check queues with other names, we just check the current queue. I propose to include the queue name in the task ID hash to prevent issues with removing unique tasks. Alternatively, we'd have to check all other queues for tasks before removing a unique task, or have some kind of reference counter.
This is potentially a breaking change.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by tracing how unique task objects are removed from Redis and how task IDs are formed across queues. Compare the current queue checks with tasks in other queues; done means unique tasks cannot be removed while referenced by another queue, with the breaking-change impact resolved.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python, redis
- Domain
- backend, distributed-systems
- Issue type
- Bug
- Difficulty
- 5/5
- Estimated time
- Over a week
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 30/100