closeio / closeio/tasktiger

Refactor keys to avoid duplicate string literals

Open
#255 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.5k
Forks
95
Avg merge
4d 21h
Merged PRs (30d)
1

Description

We're currently using a lot of string literals for building Redis keys, and it's relatively easy to make a typo that might go unnoticed.

It would be nice if we could improve on this.

Maybe use a separate method for generating each key?
Or perhaps simply use constants instead of literals such as "task" or "executions", the way we already do for QUEUED, SCHEDULED, etc.?

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Redis key construction and the existing QUEUED and SCHEDULED constants. Compare the repeated literals such as "task" and "executions", then determine a consistent key-generation or constant approach; done means key construction no longer duplicates these strings without changing key behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
python, redis
Domain
backend, databases
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
32/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.