closeio / closeio/tasktiger

Refactor queue config settings

Open
#122 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
1.5k
Forks
95
Avg merge
4d 21h
Merged PRs (30d)
1

Description

Right now a queue's configuration is spread across multiple keys in the config. We should move to something like this instead and stop using the separate settings ONLY_QUEUES, BATCH_QUEUES, SINGLE_WORKER_QUEUES/MAX_WORKERS_PER_QUEUE?

QUEUES = {
    'a': {
        max_workers: 5,
        batch: 50
    },
    'b': {}
}

The SINGLE_WORKER_QUEUES setting should be deprecated since MAX_WORKERS_PER_QUEUE=1 is equivalent. Max workers was added in https://github.com/closeio/tasktiger/pull/115.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by searching the repository for ONLY_QUEUES, BATCH_QUEUES, SINGLE_WORKER_QUEUES, and MAX_WORKERS_PER_QUEUE to map their configuration and call sites. Implement the proposed QUEUES structure with per-queue max_workers and batch settings, deprecate SINGLE_WORKER_QUEUES, and verify existing queue behavior and compatibility.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
backend
Issue type
Refactor
Difficulty
4/5
Estimated time
3-5 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.