Ensure Google events sync has a channel token
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 30
- Forks
- 13
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 8
Description
I cannot find where we enable the Google channel token header in the webhooks or validate it. The option is off by default. Do we know that we are setting it? If not, we should enable it since it is effectively the password to the corresponding channel id.
Related code:
https://github.com/closeio/nylas/blob/n17/inbox/events/remote_sync.py
https://github.com/closeio/nylas/blob/n17/inbox/events/google.py
Information about the id and token headers can be found here:
https://developers.google.com/calendar/v3/push#understanding-the-notification-message-format
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start with inbox/events/remote_sync.py and inbox/events/google.py, then compare their webhook handling with Google's notification message format documentation. Confirm whether the channel token header is enabled and validated; done means Google event notifications use the token for the corresponding channel ID.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- google-cloud, python
- Domain
- backend, security
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 35/100