Clearer logging of the account ID responsible for a blocking greenlet
Nobody has claimed this yet.
- Dominant language
- Python
- Stars
- 30
- Forks
- 13
- Avg merge
- 1d 2h
- Merged PRs (30d)
- 8
Description
When processing of an account blocks other greenlets, we log a warning about it here: https://github.com/closeio/sync-engine/blob/e37f19ab6309a0e9a040ef15ab5e236cec0f3ad9/inbox/instrumentation.py#L174-L177
An example of a context logged is foldersyncengine:26:60 where 26 corresponds to the ID of the account being processed. I suggest that, instead of logging an enigmatic context, we should log an explicit account_id=context.split(':')[1] in this warning. I did NOT confirm that the format of the context is always the same though.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in inbox/instrumentation.py at lines 174-177 and inspect how the blocking-greenlet warning receives and formats context. Confirm whether the context format is consistent, then make the warning identify the responsible account explicitly instead of exposing only the opaque context.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- python
- Domain
- observability
- Issue type
- Feature
- Difficulty
- 2/5
- Estimated time
- 1-3 hours
- Activity status
- Stale
- Clarity
- Mostly clear
- Newbie friendliness
- 45/100