closeio / closeio/sync-engine

Remove `type: ignore` mypy comments

Open
#1,002 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Python
Stars
30
Forks
13
Avg merge
1d 2h
Merged PRs (30d)
8

Description

Remove type: ignore comments.

Current counts for each ignored mypy error code:

  • exit-return: 1
  • func-returns-value: 1
  • has-type: 1
  • list-item: 1
  • return: 1
  • truthy-bool: 1
  • used-before-def: 1
  • method-assign: 2
  • return-value: 2
  • truthy-iterable: 2
  • comparison-overlap: 3
  • dict-item: 5
  • type-arg: 5
  • redundant-expr: 6
  • operator: 7
  • call-overload: 8
  • import-not-found: 8
  • index: 8
  • no-redef: 9
  • name-defined: 10
  • union-attr: 14
  • override: 15
  • unreachable: 16
  • arg-type: 18
  • assignment: 25
  • possibly-undefined: 37
  • var-annotated: 42
  • valid-type: 79
  • misc: 89
  • call-arg: 90
  • attr-defined: 247
  • import-untyped: 483
  • no-untyped-def: 927

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating the Python files containing the listed type: ignore comments and group them by mypy error code. Review each ignored error and determine the required typing or code change before removing the comment. Done means the listed ignore counts reach zero and mypy no longer reports those errors.

Written by the indexing model from the issue text.

Assessment

Tech stack
python
Domain
tooling
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Stale
Clarity
Needs clarification
Newbie friendliness
25/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.