clojure / clojure/clojurescript-site

Update the version number of figwheel-sidecar in the ProtoREPL instructions

Open
#287 1 comment 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

minor
Dominant language
Shell
Stars
107
Forks
130
PR merge metrics
No merged PRs in 30d

Description

I followed the instructions at https://clojurescript.org/tools/atom#proto-repl and I encountered an issue running this command, as listed in the instructions:

(do (use 'figwheel-sidecar.repl-api) (start-figwheel!) (cljs-repl))

This threw a spec error, the same one shown here and here, and I couldn't run the REPL. Most likely one of my dependencies uses an older version of clojure.async that causes this problem.

I followed @bhauman's instructions from this comment, by bumping up the figwheel-sidecar dependency to 0.5.10. After that, I was able to run the clojurescript repl in the atom protorepl.

I propose at minimum updating the figwheel-sidecar version to 5.10 to prevent new users to the protoREPL from encountering this. The whole dependencies section could possibly use some updating, though.

I also tested this on a brand new app built using the template from "lein new figwheel ...". Everything worked as expected.

*Edit: this all occurred while running Clojure 1.9.0 and Clojurescript 1.10.238

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the ProtoREPL instructions at the linked clojurescript.org/tools/atom#proto-repl entry point and inspect the dependencies section. Update the figwheel-sidecar version to the version described in the issue, then verify that the documented REPL command works with the updated instructions.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure
Domain
documentation
Issue type
Documentation
Difficulty
1/5
Estimated time
Under an hour
Activity status
Stale
Clarity
Clearly specified
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.