clojure-emacs / clojure-emacs/cider

[nrepl-client] Automatically disjoin false/nil keys from requests

Open
#2,854 2 comments 0 reactions 0 assignees View on GitHub
enhancement good first issue
Dominant language
Emacs Lisp
Stars
3.7k
Forks
651
Avg merge
11h 6m
Merged PRs (30d)
33

Description

As you can't encode false/nil with bencode you're actually supposed not to send such flags, but I guess people do it from time to time by mistake. It'd be nice if we simply disjoined them automatically before sending a request to nREPL.

Contributor guide

Open the contributing guide

Research direction

Read the nrepl-client request path and inspect how requests are prepared before being sent to nREPL. Ensure false and nil keys are omitted before encoding, then add or run tests covering requests containing those values and confirm valid keys remain unchanged.

Written by the indexing model from the issue text.

Assessment

Tech stack
clojure, emacs-lisp
Domain
developer-experience
Issue type
Feature
Difficulty
2/5
Estimated time
1-3 hours
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
45/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.