clockworklabs / clockworklabs/SpacetimeDB

Add test for `find_updates` that catches `.all(..)` vs. `.any(...)`

Open
#989 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
25.2k
Forks
1.1k
Avg merge
2d 7h
Merged PRs (30d)
46

Description

See https://github.com/clockworklabs/SpacetimeDB/pull/988/files#diff-58359ced4f85a6b1ab5721c3918ef1aad5a626f6949985e18f913e3b775ae2b6R357-R359.

In my PR this was originally .any(...) but the immediate test suite did not catch it.
We should add a test for that.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start with the linked pull request diff, especially the code around lines 357–359, and locate the find_updates implementation. Review the existing immediate test suite, then add a regression test that distinguishes .all(...) from .any(...). Run the relevant test suite and confirm it catches the incorrect behavior.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
databases, testing
Issue type
Bug
Difficulty
3/5
Estimated time
1-2 days
Activity status
Stale
Clarity
Mostly clear
Newbie friendliness
42/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.