clockworklabs / clockworklabs/SpacetimeDB
Classify database update failures for logging
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 25.2k
- Forks
- 1.1k
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 46
Description
Follow-up from https://github.com/clockworklabs/SpacetimeDB/pull/5640.
In crates/core/src/host/wasm_common/module_host_actor.rs, InstanceCommon::update_database logs every error returned by crate::db::update::update_database at warn!.
This combines migration/schema rejections with possible internal datastore failures in a single anyhow::Error. Audit whether they can be classified without a large refactor so internal failures potentially use error!, while migration rejections remain at warn! or lower.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start in crates/core/src/host/wasm_common/module_host_actor.rs at InstanceCommon::update_database, then trace errors returned by crate::db::update::update_database. Audit whether migration/schema rejections and internal datastore failures can be distinguished without a large refactor. Done means internal failures can be logged at error! while migration rejections remain at warn! or lower.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- databases, observability
- Issue type
- Refactor
- Difficulty
- 4/5
- Estimated time
- 3-5 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100