clockworklabs / clockworklabs/SpacetimeDB
Render arrays correctly in SQL
Nobody has claimed this yet.
- Dominant language
- Rust
- Stars
- 25.2k
- Forks
- 1.1k
- Avg merge
- 2d 7h
- Merged PRs (30d)
- 46
Description
This issue tracks reimplementing the work from stale PR #3945, which has been closed because it is too far out of date to merge directly.
Original pull request
- PR #3945: Render arrays correctly in SQL
- Original author: @mamcx
What the original PR was trying to do
Description of Changes As the title says. API and ABI breaking changes Before arrays incorrectly display and only for the first item. Expected complexity level and risk 1 Testing - [x] Smoke and unit tests - [] No inspected in another client outside psql
Closure context
- Needs to be reimplemented because of the out of date smoketest.
Reimplementation notes
- Reimplement this work on top of current
masterin a new PR. - Keep the original PR linked as historical context and as a source of useful implementation ideas where still relevant.
Contributor guide
No contributing guide indexed for this repository
First steps
- Read the whole issue, then the project's contributing guide.
- Comment on the issue to say you are picking it up — it saves two people doing the same work.
- Fork the repository and make your change on a branch.
- Open a pull request that references the issue number.
Research direction
Start by reviewing stale PR #3945 and compare its approach with the current master branch, especially the out-of-date smoketest mentioned in the issue. Reimplement the array rendering behavior so arrays display all items correctly in SQL, then run the smoke and unit tests; testing in another client outside psql is not specified.
Written by the indexing model from the issue text.
Assessment
- Tech stack
- rust
- Domain
- databases
- Issue type
- Bug
- Difficulty
- 3/5
- Estimated time
- 1-2 days
- Activity status
- Quiet
- Clarity
- Mostly clear
- Newbie friendliness
- 48/100