clockworklabs / clockworklabs/SpacetimeDB

Reimplement: Add per-client queue length metrics

Open
#4,796 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

release-any
Dominant language
Rust
Stars
25.2k
Forks
1.1k
Avg merge
2d 7h
Merged PRs (30d)
46

Description

This issue tracks reimplementation of the work from stale PR #2754, which is being closed because it is too out of date to merge directly.

    Original PR: https://github.com/clockworklabs/SpacetimeDB/pull/2754
    Original author: @gefjon
    Original branch: `phoebe/metric-client-queue-length`
    Base branch: `master`

    ## Original PR summary

    # Description of Changes

This PR adds two new metrics, spacetime_client_connection_incoming_queue_length and spacetime_client_connection_outgoing_queue_length, which track the lengths of the per-client incoming and outgoing message queues. We expect to use these metrics in testing, incl. bot testing, but not to merge them, as we expect the cardinality of per-client metrics to be too high. I will open a separate PR with per-database versions of these metrics which we can merge.

    ## Follow-up

    - Reimplement this change in a fresh PR against current `master`.
    - Carry forward any still-relevant context from the original PR discussion and review.
    - Link the new implementation PR back to the original stale PR for historical context.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing stale PR #2754 and its discussion, then compare the metric instrumentation on the current master branch. Reimplement the still-relevant per-client incoming and outgoing queue length metrics in a fresh PR, preserving the named metric behavior and linking back to PR #2754.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
observability
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
50/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.