clockworklabs / clockworklabs/SpacetimeDB

Reimplement: websocket: send/receive reducer & table ids instead of names (take 2)

Open
#4,792 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

api-break
Dominant language
Rust
Stars
25.2k
Forks
1.1k
Avg merge
2d 7h
Merged PRs (30d)
46

Description

This issue tracks reimplementation of the work from stale PR #1940, which is being closed because it is too out of date to merge directly.

    Original PR: https://github.com/clockworklabs/SpacetimeDB/pull/1940
    Original author: @Centril
    Original branch: `centril/name-keyed-websocket-use-ids`
    Base branch: `master`

    ## Original PR summary

    # Description of Changes

Receive and send reducer ids and table ids as opposed to names in the SDK.

Alternative to https://github.com/clockworklabs/SpacetimeDB/pull/1883 which is more efficient, but also uses indices internally rather than strings, making the diff larger.

API and ABI breaking changes

Yes.

    ## Follow-up

    - Reimplement this change in a fresh PR against current `master`.
    - Carry forward any still-relevant context from the original PR discussion and review.
    - Link the new implementation PR back to the original stale PR for historical context.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing stale PR #1940, its discussion, and the centril/name-keyed-websocket-use-ids branch, then compare the proposal with current master. Reimplement the still-relevant change in a fresh PR, account for the documented API and ABI break, and link the new implementation back to PR #1940.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
api, backend-api-design
Issue type
Refactor
Difficulty
5/5
Estimated time
Over a week
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
35/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.