clockworklabs / clockworklabs/SpacetimeDB

Reimplement: Dedup (aka DISTINCT) support on PhysicalPlan

Open
#4,791 0 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

backward-compatible release-any
Dominant language
Rust
Stars
25.2k
Forks
1.1k
Avg merge
2d 7h
Merged PRs (30d)
46

Description

This issue tracks reimplementation of the work from stale PR #1914, which is being closed because it is too out of date to merge directly.

    Original PR: https://github.com/clockworklabs/SpacetimeDB/pull/1914
    Original author: @mamcx
    Original branch: `mamcx/distinct`
    Base branch: `master`

    ## Original PR summary

    # Description of Changes

As the title says.

Expected complexity level and risk

1

Testing

Describe any testing you've done, and any testing you'd like your reviewers to do,
so that you're confident that all the changes work as expected!

  • Write a test you've completed here.

  • Write a test you want a reviewer to do here, so they can check it off when they're satisfied.

      ## Follow-up
    
      - Reimplement this change in a fresh PR against current `master`.
      - Carry forward any still-relevant context from the original PR discussion and review.
      - Link the new implementation PR back to the original stale PR for historical context.
    

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by reviewing stale PR #1914 and comparing its DISTINCT implementation with the current master branch, focusing on PhysicalPlan. Carry forward relevant review context, reimplement the support against current master, and add or preserve the completed test coverage so DISTINCT behavior is verified.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
databases
Issue type
Feature
Difficulty
3/5
Estimated time
1-2 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.