clockworklabs / clockworklabs/SpacetimeDB

Fix issue with db.lock files

Open
#4,771 5 comments 0 reactions 0 assignees View on GitHub

Nobody has claimed this yet.

Dominant language
Rust
Stars
25.2k
Forks
1.1k
Avg merge
2d 7h
Merged PRs (30d)
46

Description

Currently we write a db.lock file in the replica directory for each replica, however, this should really not be necessary since we already have a data-dir lockfile. This db.lock lock file has caused us issues with databases not being able open, so we would like to remove this file.

TODO:

  • Investigate and ensure that this lockfile is truly redundant
  • Ensure that opening the replica twice will not have problems
  • Remove the lockfile.

Contributor guide

No contributing guide indexed for this repository

First steps

  1. Read the whole issue, then the project's contributing guide.
  2. Comment on the issue to say you are picking it up — it saves two people doing the same work.
  3. Fork the repository and make your change on a branch.
  4. Open a pull request that references the issue number.

Research direction

Start by locating where db.lock is created in each replica directory and where the existing data-dir lockfile is handled. Verify that opening a replica twice remains safe without the replica lock, then remove the redundant lockfile and confirm the database opens successfully.

Written by the indexing model from the issue text.

Assessment

Tech stack
rust
Domain
databases
Issue type
Bug
Difficulty
4/5
Estimated time
3-5 days
Activity status
Quiet
Clarity
Mostly clear
Newbie friendliness
48/100

Get new issues in your inbox

A short digest of beginner-friendly GitHub issues.